Bug 212676

Summary:

VMInspector APIs should be taking a VM* instead of a JSGlobalObject*.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	saam: review+

Description Mark Lam 2020-06-02 17:55:39 PDT

This because:
1. none of the functions currently taking a JSGlobalObject* actually need the globalObject.  All of them need the VM.
2. the role of the VMInspector is to enable inspection of the VM.  By requiring that it be passed a JSGlobalObject*, we were actually preventing the VMInspector from being used in code that have a VM to inspect but don't have a JSGlobalObject to use.

Comment 1 Mark Lam 2020-06-02 18:00:09 PDT

Created attachment 400871 [details]
proposed patch.

Comment 2 Mark Lam 2020-06-02 18:26:21 PDT

Thanks for the reviews.  Landed in r262467: <http://trac.webkit.org/r262467>.

Comment 3 Radar WebKit Bug Importer 2020-06-02 18:27:16 PDT

<rdar://problem/63902729>