| Summary: | Resync web-platform-tests/2dcontext from upstream | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||
| Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | achristensen, clopez, dino, ggaren, jacob_uphoff, sabouhallawa, webkit-bug-importer, youennf | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=212613 https://bugs.webkit.org/show_bug.cgi?id=212770 |
||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||
| Bug Blocks: | 213927 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Chris Dumez
2020-06-02 09:14:51 PDT
Those tests got moved upstream: 2dcontext -> html/canvas/element Created attachment 400840 [details]
Patch
Created attachment 400847 [details]
Patch
Created attachment 400850 [details]
Patch
Created attachment 400868 [details]
Patch
Created attachment 400898 [details]
Patch
As of LayoutTests/canvas/philip/tests/2d.drawImage.incomplete.emptysrc.html and siblings, they are probably obsoleted by WPT tests. If so, it might be good to remove them. Said, wdyt? Tools/Scripts/svn-apply failed to apply attachment 400898 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 400940 [details]
Patch
commit-queue failed to commit attachment 400940 [details] to WebKit repository.
Created attachment 400963 [details]
Patch
commit-queue failed to commit attachment 400963 [details] to WebKit repository.
Committed r262527: <https://trac.webkit.org/changeset/262527> (In reply to Chris Dumez from comment #13) > Committed r262527: <https://trac.webkit.org/changeset/262527> I was working on a similar patch on bug 212613 when i noticed this landing. I don't know how you did this import or what went wrong, but I see it is missing the import of all the new canvas tests. Upstream WPT moved "2dcontext" -> "html/canvas/element" but on r262527 I see no folder LayoutTests/imported/w3c/web-platform-tests/html/canvas Where are the new tests? Also some other tests had resources to that folder that now not longer exist. See all the new failures: https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/13538/steps/layout-test/logs/stdio What surprises me is how the EWS was green.. maybe the patch landed was different than the one tested by the EWS? (In reply to Carlos Alberto Lopez Perez from comment #15) > (In reply to Chris Dumez from comment #13) > > Committed r262527: <https://trac.webkit.org/changeset/262527> > > I was working on a similar patch on bug 212613 when i noticed this landing. > > I don't know how you did this import or what went wrong, but I see it is > missing the import of all the new canvas tests. > > Upstream WPT moved "2dcontext" -> "html/canvas/element" but on r262527 I see > no folder LayoutTests/imported/w3c/web-platform-tests/html/canvas > > Where are the new tests? > > > Also some other tests had resources to that folder that now not longer exist. > > See all the new failures: > https://build.webkit.org/builders/ > Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/13538/steps/layout-test/ > logs/stdio > > > What surprises me is how the EWS was green.. maybe the patch landed was > different than the one tested by the EWS? The commit queue refused to commit the patch, likely because it was too big. I had to land manually. It is likely I messed up my local commit and missed new files based on what you are saying. I will look into fixing this this morning. Committed r262539: <https://trac.webkit.org/changeset/262539> |