| Summary: | Fix broken Windows build. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, changseok, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2020-06-02 06:53:10 PDT
Created attachment 400815 [details]
speculative fix.
Comment on attachment 400815 [details] speculative fix. View in context: https://bugs.webkit.org/attachment.cgi?id=400815&action=review r=me > Source/WebCore/html/HTMLCanvasElement.cpp:1022 > Is needsPreparationForDisplay OK? It also includes WebGLRenderingContextBase (In reply to Yusuke Suzuki from comment #2) > Comment on attachment 400815 [details] > speculative fix. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=400815&action=review > > r=me > > > Source/WebCore/html/HTMLCanvasElement.cpp:1022 > > > > Is needsPreparationForDisplay OK? It also includes WebGLRenderingContextBase Thanks for catching that. It's strange that the bot didn't complain about it. I'll add the WEBGL guard around it too. Landed in r262418: <http://trac.webkit.org/r262418>. |