Bug 212631

Summary:

UIColor and NSColor WebCore::Color factories should return invalid colors for nil input colors

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, sam, simon.fraser, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review+

Description Tim Horton 2020-06-02 01:59:14 PDT

UIColor and NSColor WebCore::Color factories should return invalid colors for nil input colors

Comment 1 Tim Horton 2020-06-02 01:59:36 PDT

Created attachment 400798 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2020-06-02 01:59:58 PDT

<rdar://problem/63865676>

Comment 3 Anders Carlsson 2020-06-02 07:28:14 PDT

Comment on attachment 400798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400798&action=review

> Source/WebCore/platform/graphics/mac/ColorMac.mm:98
> +        return Color();

Can probably just return { } here.

> Source/WebCore/platform/graphics/mac/ColorMac.mm:108
> +        return Color();

Same.

> Source/WebCore/platform/ios/ColorIOS.mm:38
> +        return Color();

Same.

Comment 4 Tim Horton 2020-06-02 10:10:37 PDT

True!

Comment 5 Tim Horton 2020-06-02 10:12:03 PDT

https://trac.webkit.org/changeset/262428/webkit