Bug 212630

Summary:

macCatalyst: WKWebView's tint color is not propagated to Web Content process

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, darin, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review+

Description Tim Horton 2020-06-02 01:51:24 PDT

macCatalyst: WKWebView's tint color is not propagated to Web Content process

Comment 1 Tim Horton 2020-06-02 01:51:49 PDT

Created attachment 400797 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2020-06-02 01:52:16 PDT

<rdar://problem/63865456>

Comment 3 Tim Horton 2020-06-02 10:15:10 PDT

https://trac.webkit.org/changeset/262429/webkit

Comment 4 Darin Adler 2020-06-02 10:18:45 PDT

Comment on attachment 400797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400797&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.h:1571
> +    void setTintColor(WebCore::Color);

Since extended colors are reference counted, it seems slightly better to use const WebCore::Color& here.