| Summary: | m_userActivatedMediaFinishedPlayingTimestamp is used uninitialized | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yoshiaki Jitsukawa <yoshiaki.jitsukawa> | ||||
| Component: | Media | Assignee: | Yoshiaki Jitsukawa <yoshiaki.jitsukawa> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | ahmad.saleem792, cdumez, esprehn+autocc, ews-watchlist, kangil.han, peng.liu6, youennf | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yoshiaki Jitsukawa
2020-06-02 01:03:32 PDT
Created attachment 400793 [details]
Patch
Comment on attachment 400793 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400793&action=review > Source/WebCore/dom/Document.cpp:6826 > + if (m_userActivatedMediaFinishedPlayingTimestamp && (m_userActivatedMediaFinishedPlayingTimestamp + maxIntervalForUserGestureForwardingAfterMediaFinishesPlaying >= MonotonicTime::now())) Can you explain the issue? Is it that MonotonicTime::now might return a value close to 0 on the playstation? I would expect in general MonotonicTime::now() to have a high value so that, if m_userActivatedMediaFinishedPlayingTimestamp is zero, we always fail the if check. (In reply to youenn fablet from comment #2) > Comment on attachment 400793 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=400793&action=review > > > Source/WebCore/dom/Document.cpp:6826 > > + if (m_userActivatedMediaFinishedPlayingTimestamp && (m_userActivatedMediaFinishedPlayingTimestamp + maxIntervalForUserGestureForwardingAfterMediaFinishesPlaying >= MonotonicTime::now())) > > Can you explain the issue? Is it that MonotonicTime::now might return a > value close to 0 on the playstation? > I would expect in general MonotonicTime::now() to have a high value so that, > if m_userActivatedMediaFinishedPlayingTimestamp is zero, we always fail the > if check. Sorry for late reply. Yes, on the playstation port MonotonicTime::now() may return such a value. If m_userActivatedMediaFinishedPlayingTimestamp is zero, it implies that nobody has set it, correct? Comment on attachment 400793 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400793&action=review >>> Source/WebCore/dom/Document.cpp:6826 >>> + if (m_userActivatedMediaFinishedPlayingTimestamp && (m_userActivatedMediaFinishedPlayingTimestamp + maxIntervalForUserGestureForwardingAfterMediaFinishesPlaying >= MonotonicTime::now())) >> >> Can you explain the issue? Is it that MonotonicTime::now might return a value close to 0 on the playstation? >> I would expect in general MonotonicTime::now() to have a high value so that, if m_userActivatedMediaFinishedPlayingTimestamp is zero, we always fail the if check. > > Sorry for late reply. > Yes, on the playstation port MonotonicTime::now() may return such a value. > > If m_userActivatedMediaFinishedPlayingTimestamp is zero, it implies that nobody has set it, correct? Sounds like MonotonicTime::now() has some issue on the playstation port? This didn't landed: https://searchfox.org/wubkat/source/Source/WebCore/dom/Document.cpp#7621 Do we need this? |