Bug 212621

Summary:

MultiDeleteByOffset should not always def

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ross.kirsling, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Saam Barati 2020-06-01 17:26:43 PDT

Because it doesn't actually always def, it depends on its cases

Comment 1 Saam Barati 2020-06-01 17:27:02 PDT

<rdar://problem/63824182>

Comment 2 Saam Barati 2020-06-01 17:36:13 PDT

Created attachment 400774 [details]
patch

Comment 3 Saam Barati 2020-06-01 17:36:47 PDT

Comment on attachment 400774 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400774&action=review

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:-8474
> -            if (variant.newStructure()) {

this is a refactoring, since above, we have the code:

if (!variant.newStructure()) continue;

Comment 4 Yusuke Suzuki 2020-06-02 09:27:53 PDT

Comment on attachment 400774 [details]
patch

r=me

Comment 5 EWS 2020-06-02 09:55:19 PDT

Committed r262425: <https://trac.webkit.org/changeset/262425>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400774 [details].