Bug 212620

Summary: Add ENABLE(WHEEL_EVENT_REGIONS), enabled on macOS which is the only platform that needs wheel event regions for scrolling thread hit-testing
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, changseok, cmarcelo, darin, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Simon Fraser (smfr) 2020-06-01 16:54:05 PDT 
Add ENABLE(WHEEL_EVENT_REGIONS), enabled on macOS which is the only platform that needs wheel event regions for scrolling thread hit-testing
Comment 1 Simon Fraser (smfr) 2020-06-01 16:55:49 PDT 
Created attachment 400769 [details]
Patch
Comment 2 Darin Adler 2020-06-01 17:36:52 PDT 
Comment on attachment 400769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400769&action=review

> Source/WTF/wtf/PlatformEnable.h:495
> +#if !defined(ENABLE_WHEEL_EVENT_REGIONS)
> +#define ENABLE_WHEEL_EVENT_REGIONS 0
> +#endif

We only need these for things that default to 1. I am planning on removing the items here that default to 0. The list is not complete, so it doesn’t document all the enable settings, and there is no effect if any particular one is removed.

I think you can just omit this entirely.
Comment 3 Simon Fraser (smfr) 2020-06-02 13:17:48 PDT 
https://trac.webkit.org/changeset/262437/webkit
Comment 4 Radar WebKit Bug Importer 2020-06-02 13:18:19 PDT 
<rdar://problem/63889023>