Bug 212613

Summary: Update WPT tests for offscreen-canvas (and rename to html/canvas/offscreen)
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, clord, darin, dpino, rego, simon.fraser, webkit-bug-importer, youennf, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212661
https://bugs.webkit.org/show_bug.cgi?id=212639
https://bugs.webkit.org/show_bug.cgi?id=236474
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Carlos Alberto Lopez Perez
Reported 2020-06-01 14:36:27 PDT
On WPT the following renaming happened: 2dcontext -> html/canvas/element offscreen-canvas -> html/canvas/offscreen See: https://github.com/web-platform-tests/wpt/issues/22979 We should re-import this tests and adjust the paths for all expectations accordingly
Attachments
Patch (16.81 MB, patch)
2020-06-01 14:44 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (16.86 MB, patch)
2020-06-02 04:11 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (9.95 MB, patch)
2020-06-04 13:31 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2020-06-01 14:44:45 PDT
Created attachment 400761 [details] Patch Ignore for now. Test EWS
Carlos Alberto Lopez Perez
Comment 2 2020-06-02 04:11:07 PDT
Created attachment 400802 [details] Patch Ignore for now. Test EWS
Diego Pino
Comment 3 2020-06-04 03:37:43 PDT
The 2dcontext tests have been resynced in r262527. After that the offscreen-canvas tests started failing. I've disabled the offscreen-canvas tests temporarily in https://bugs.webkit.org/show_bug.cgi?id=212738 to make the test bots pass as there were >500 failures.
Carlos Alberto Lopez Perez
Comment 4 2020-06-04 04:13:31 PDT
re-title bug to re-import the offscreen canvas tests only
Chris Dumez
Comment 5 2020-06-04 08:23:17 PDT
(In reply to Carlos Alberto Lopez Perez from comment #4) > re-title bug to re-import the offscreen canvas tests only Sounds good. Sorry about the conflict, I did not realize someone else was working on resync-ing those tests too.
Carlos Alberto Lopez Perez
Comment 6 2020-06-04 13:11:31 PDT
(In reply to Chris Dumez from comment #5) > (In reply to Carlos Alberto Lopez Perez from comment #4) > > re-title bug to re-import the offscreen canvas tests only > > Sounds good. Sorry about the conflict, I did not realize someone else was > working on resync-ing those tests too. No problem :) It's kind of hard to avoid this conflicts, but they are easy to fix :) I'm uploading now the patch with the update for offscreen canvas tests. I tested that all of them pass ok in GTK, (WPE should pass; didn't tested)... and the rest of platforms are skipping this tests, so they should be good to go (no need to wait for EWS in this case).
Carlos Alberto Lopez Perez
Comment 7 2020-06-04 13:31:54 PDT
Created attachment 401074 [details] Patch
Carlos Alberto Lopez Perez
Comment 8 2020-06-04 18:50:58 PDT
All EWS green... r?
EWS
Comment 9 2020-06-05 06:53:36 PDT
Committed r262615: <https://trac.webkit.org/changeset/262615> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401074 [details].
Radar WebKit Bug Importer
Comment 10 2020-06-05 09:57:22 PDT
<rdar://problem/64033245>
Radar WebKit Bug Importer
Comment 11 2020-06-05 09:57:30 PDT
<rdar://problem/64033248>
Note You need to log in before you can comment on or make changes to this bug.