| Summary: | Update WPT tests for offscreen-canvas (and rename to html/canvas/offscreen) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||||
| Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, clord, darin, dpino, rego, simon.fraser, webkit-bug-importer, youennf, zan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=212661 https://bugs.webkit.org/show_bug.cgi?id=212639 https://bugs.webkit.org/show_bug.cgi?id=236474 |
||||||||||
| Attachments: |
|
||||||||||
Created attachment 400761 [details]
Patch
Ignore for now. Test EWS
Created attachment 400802 [details]
Patch
Ignore for now. Test EWS
The 2dcontext tests have been resynced in r262527. After that the offscreen-canvas tests started failing. I've disabled the offscreen-canvas tests temporarily in https://bugs.webkit.org/show_bug.cgi?id=212738 to make the test bots pass as there were >500 failures. re-title bug to re-import the offscreen canvas tests only (In reply to Carlos Alberto Lopez Perez from comment #4) > re-title bug to re-import the offscreen canvas tests only Sounds good. Sorry about the conflict, I did not realize someone else was working on resync-ing those tests too. (In reply to Chris Dumez from comment #5) > (In reply to Carlos Alberto Lopez Perez from comment #4) > > re-title bug to re-import the offscreen canvas tests only > > Sounds good. Sorry about the conflict, I did not realize someone else was > working on resync-ing those tests too. No problem :) It's kind of hard to avoid this conflicts, but they are easy to fix :) I'm uploading now the patch with the update for offscreen canvas tests. I tested that all of them pass ok in GTK, (WPE should pass; didn't tested)... and the rest of platforms are skipping this tests, so they should be good to go (no need to wait for EWS in this case). Created attachment 401074 [details]
Patch
All EWS green... r? Committed r262615: <https://trac.webkit.org/changeset/262615> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401074 [details]. |
On WPT the following renaming happened: 2dcontext -> html/canvas/element offscreen-canvas -> html/canvas/offscreen See: https://github.com/web-platform-tests/wpt/issues/22979 We should re-import this tests and adjust the paths for all expectations accordingly