Bug 212603

Summary:

x86.rb's LabelReference.x86LoadOperand()'s address operand should be a pointer type.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	saam: review+

Description Mark Lam 2020-06-01 12:19:13 PDT

The current implementation mistakenly sets the address type to that of the value being loaded.

Comment 1 Mark Lam 2020-06-01 12:23:04 PDT

Created attachment 400746 [details]
proposed patch.

Comment 2 Yusuke Suzuki 2020-06-01 12:35:17 PDT

Comment on attachment 400746 [details]
proposed patch.

r=me too

Comment 3 Mark Lam 2020-06-01 12:36:35 PDT

Thanks for the review.  Landed in r262389: <http://trac.webkit.org/r262389>.

Comment 4 Radar WebKit Bug Importer 2020-06-01 12:37:18 PDT

<rdar://problem/63839299>