| Summary: | Rename Signal::BadAccess to Signal::AccessFault. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 212575 | ||||||
| Attachments: |
|
||||||
Created attachment 400695 [details]
proposed patch.
Comment on attachment 400695 [details]
proposed patch.
r=me
Thanks for the review. Landed in r262355: <http://trac.webkit.org/r262355>. |
This is needed because GTK port's X11 has a #define for BadAccess (in include/X11/X.h): #define BadAccess 10 /* depending on context: - key/button already grabbed - attempt to free an illegal cmap entry - attempt to store into a read-only color map entry. - attempt to modify the access control list from other than the local host. */ As a result, this breaks the GTK build when wtf/Signals.h is #include'd.