| Summary: | Change JSC::Config to use storage in WTF::Config instead of its own. | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 212577 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Mark Lam
2020-05-30 16:02:17 PDT
Created attachment 400682 [details]
proposed patch.
Created attachment 400684 [details]
proposed patch.
Created attachment 400685 [details]
propose patch.
Comment on attachment 400685 [details]
propose patch.
I think this is ready for a review.
It seems that GTK bot is failing, can you take a look? (In reply to Yusuke Suzuki from comment #6) > It seems that GTK bot is failing, can you take a look? I looked. That failure is very strange. I didn't touch that code in this patch. So, I'm not sure how it ever built before if it's not building now. (In reply to Mark Lam from comment #7) > (In reply to Yusuke Suzuki from comment #6) > > It seems that GTK bot is failing, can you take a look? > > I looked. That failure is very strange. I didn't touch that code in this > patch. So, I'm not sure how it ever built before if it's not building now. I see what may be happening. JSCConfig.h now #include WTFConfig.h, and this somehow messes up GTK's build. Still investigating. Created attachment 400691 [details]
test wild guess that BadAccess is some #define in gtk/X11 code.
Created attachment 400693 [details]
test wild guess that BadAccess is some #define in gtk/X11 code.
GTK build failure is due to https://bugs.webkit.org/show_bug.cgi?id=212577, which is now fixed. Comment on attachment 400685 [details]
propose patch.
r=me
Comment on attachment 400685 [details]
propose patch.
Thanks for the review. Landing now.
Committed r262356: <https://trac.webkit.org/changeset/262356> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400685 [details]. |