| Summary: | [GTK][WPE][EME] Update WPT and rebaseline | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Charlie Turner <cturner> | ||||||||||||
| Component: | WebKitGTK | Assignee: | Charlie Turner <cturner> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bugs-noreply, calvaris, clopez, eric.carlson, ews-watchlist, glenn, jer.noble, lmoura, philipj, sergio, youennf | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 212586 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Charlie Turner
2020-05-30 13:52:53 PDT
Created attachment 400677 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Created attachment 400678 [details]
Patch
I don't think I need to do anything to the WPT repo since I am only pulling from them (from a while ago now). I included the EME tests as a feature category of glib TestExpectations. As discussed offline I thought we agreed to organize the file by feature rather than test status
(In reply to Charlie Turner from comment #3) > I included the EME tests as a feature > category of glib TestExpectations. As discussed offline I thought we agreed > to organize the file by feature rather than test status Yes, that is still the plan but I had not yet converted it (just submitted in bug212586). (In reply to Lauro Moura from comment #4) > (In reply to Charlie Turner from comment #3) > > I included the EME tests as a feature > > category of glib TestExpectations. As discussed offline I thought we agreed > > to organize the file by feature rather than test status > > Yes, that is still the plan but I had not yet converted it (just submitted > in bug212586). I will wait for that to land, thanks for letting me know. Created attachment 401138 [details]
Patch
Created attachment 401139 [details]
Patch
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Created attachment 401266 [details]
Patch
Manually reset reviewer field. Need to figure out how to fix my workflow to avoid this nuisance
Committed r262689: <https://trac.webkit.org/changeset/262689> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401266 [details]. |