Bug 212555

Summary: Add debug alerts to xhr tests
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, clopez, ews-watchlist, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2020-05-29 17:03:08 PDT 
Add debug alerts to xhr tests
Comment 1 Alex Christensen 2020-05-29 17:04:03 PDT 
Created attachment 400636 [details]
Patch
Comment 2 EWS Watchlist 2020-05-29 17:05:28 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Alexey Proskuryakov 2020-05-29 17:26:04 PDT 
Comment on attachment 400636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400636&action=review

I would suggest console.log. alert() has interesting runloop scheduling consequences even in DRT/WKTR where it's short circuited.

> LayoutTests/imported/w3c/web-platform-tests/xhr/event-error-order.sub.html:1
> -<!DOCTYPE html>
> +<!DOCTYPE html>

Curious. I don't think that we are supposed to remove BOM from imported tests? Can revert it all together later, I guess.
Comment 4 Alex Christensen 2020-05-29 20:24:51 PDT 
Created attachment 400648 [details]
Patch
Comment 5 Alex Christensen 2020-05-29 20:30:56 PDT 
Xcode removed the BOM.  It doesn't matter with this test, but this latest patch leaves it unchanged.
We're also not supposed to put random alerts in these tests, but we're doing it in our copy anyway.
Comment 6 EWS 2020-05-29 23:28:43 PDT 
Committed r262339: <https://trac.webkit.org/changeset/262339>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400648 [details].
Comment 7 Radar WebKit Bug Importer 2020-05-29 23:29:17 PDT 
<rdar://problem/63785605>