Bug 212513

Summary:	[WPE] Assertions in W3C WebXR tests
Product:	WebKit	Reporter:	Zan Dobersek <zan>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	svillar
Priority:	P2	Keywords:	LayoutTestFailure
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	212516, 212517
Bug Blocks:

Description Zan Dobersek 2020-05-28 23:56:13 PDT

The following tests crash due to assertions in debug builds of WPE:
  imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_immersive.https.html [ Crash ]
  imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_immersive_unsupported.https.html [ Crash ]
  imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_immersive.https.html [ Crash ]
  imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_immersive_unsupported.https.html [ Crash ]
  imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_no_mode.https.html [ Crash ]
  imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_non_immersive_no_gesture.https.html [ Crash ]
  imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_optionalFeatures.https.html [ Crash ]
  imported/w3c/web-platform-tests/webxr/xrSession_cancelAnimationFrame.https.html [ Crash ]
  imported/w3c/web-platform-tests/webxr/xrSession_cancelAnimationFrame_invalidhandle.https.html [ Crash ]
  imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_callback_calls.https.html [ Crash ]

Seemingly two different crashes:

STDERR: <empty>
STDERR: ASSERTION FAILED: m_immersiveDevices.contains(device)
STDERR: ../../Source/WebCore/Modules/webxr/WebXRSystem.cpp(454) : void WebCore::WebXRSystem::unregisterSimulatedXRDeviceForTesting(PlatformXR::Device&)
STDERR: 1   0x7f176cac5fc1 WTFCrash
STDERR: 2   0x7f1765f30297 WTF::CrashOnOverflow::overflowed()
STDERR: 3   0x7f17684ac675 WebCore::WebXRSystem::unregisterSimulatedXRDeviceForTesting(PlatformXR::Device&)
STDERR: 4   0x7f167d475fe3 WebCore::WebXRTest::disconnectAllDevices(WebCore::DOMPromiseDeferred<void>&&)

STDERR: /usr/libexec/xdg-desktop-portal: No such file or directory.
STDERR: Failed to call suspendIfNeeded() for XRSystem
STDERR: ASSERTION FAILED: m_suspendIfNeededWasCalled
STDERR: ../../Source/WebCore/dom/ActiveDOMObject.cpp(104) : void WebCore::ActiveDOMObject::assertSuspendIfNeededWasCalled() const
STDERR: 1   0x7f2598509fc1 WTFCrash
STDERR: 2   0x7f2591974297 WTF::CrashOnOverflow::overflowed()
STDERR: 3   0x7f259441ac0e WebCore::ActiveDOMObject::assertSuspendIfNeededWasCalled() const
STDERR: 4   0x7f2594616f0b WebCore::ScriptExecutionContext::checkConsistency() const
STDERR: 5   0x7f259461784b WebCore::ScriptExecutionContext::stopActiveDOMObjects()
STDERR: 6   0x7f259447d128 WebCore::Document::stopActiveDOMObjects()
STDERR: 7   0x7f25944752e6 WebCore::Document::commonTeardown()
STDERR: 8   0x7f259447cb12 WebCore::Document::willBeRemovedFromFrame()
STDERR: 9   0x7f2594ec7bfd WebCore::Frame::setView(WTF::RefPtr<WebCore::FrameView, WTF::DumbPtrTraits<WebCore::FrameView> >&&)
STDERR: 10  0x7f2594eca899 WebCore::Frame::createView(WebCore::IntSize const&, WTF::Optional<WebCore::Color> const&, WebCore::IntSize const&, WebCore::IntRect const&, bool, WebCore::ScrollbarMode, bool, WebCore::ScrollbarMode, bool)
STDERR: 11  0x7f2592b06f9d WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage()

Comment 1 Sergio Villar Senin 2020-05-29 00:04:17 PDT

I'll check

Comment 2 Sergio Villar Senin 2020-05-29 03:05:39 PDT

I'm going to handle this as a metabug and fix the two crashes in two different bugs.

Comment 3 Sergio Villar Senin 2020-05-29 06:20:10 PDT

Both patches landed. Closing this.