Bug 212450

Summary: [WebInspectorUI] Inconsistent check for WI.ImageUtilities.supportsCanvasPathDebugging
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: Web InspectorAssignee: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, ews-watchlist, hi, inspector-bugzilla-changes, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Yoshiaki Jitsukawa 2020-05-27 17:54:07 PDT 
In RecordContentView.js _updateCanvasPath() should not be called if CanvasPathDebugging is not supported
otherwise _updateCanvasPath() tries to access _showPathButtonNavigationItem, which is created only if
CanvasPathDebugging is supported, but fails and raises an exception.
Comment 1 Yoshiaki Jitsukawa 2020-05-27 18:03:52 PDT 
Created attachment 400414 [details]
Patch
Comment 2 Devin Rousso 2020-05-27 18:09:59 PDT 
Comment on attachment 400414 [details]
Patch

r=me, good catch!
Comment 3 Yoshiaki Jitsukawa 2020-05-27 18:19:01 PDT 
(In reply to Devin Rousso from comment #2)
> Comment on attachment 400414 [details]
> Patch
> 
> r=me, good catch!

Thank you for the prompt review :)
Comment 4 EWS 2020-05-27 18:34:35 PDT 
Committed r262230: <https://trac.webkit.org/changeset/262230>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400414 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-27 18:35:15 PDT 
<rdar://problem/63699679>