| Summary: | Sort PlatformEnableCocoa.h and add definitions for the simple cases from FeatureDefines.xcconfig | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | WebKit Misc. | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2020-05-26 15:30:46 PDT
Created attachment 400287 [details]
Patch
Comment on attachment 400287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400287&action=review > Source/WTF/wtf/PlatformEnableCocoa.h:39 > +/* Please keep the following in alphabetical order so we can notice duplicates. */ Why not use // C++ style comments? Comment on attachment 400287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400287&action=review >> Source/WTF/wtf/PlatformEnableCocoa.h:39 >> +/* Please keep the following in alphabetical order so we can notice duplicates. */ > > Why not use // C++ style comments? I don’t know. I know these headers are very widely included, even in non-C++ files. But I don’t know if we have to support any language/compiler configuration that does not support them. Committed r262199: <https://trac.webkit.org/changeset/262199> |