| Summary: | Enhance Bitmap::setEachNthBit() to also take an end index. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | Web Template Framework | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, rmorisset, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2020-05-26 14:51:59 PDT
Created attachment 400279 [details]
proposed patch.
Comment on attachment 400279 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=400279&action=review r=me > Source/WTF/wtf/Bitmap.h:436 > + ASSERT(start <= end && end <= bitmapSize); The first ASSERT is redundant, and I would split the other ASSERT into two for better error messages. Comment on attachment 400279 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=400279&action=review >> Source/WTF/wtf/Bitmap.h:436 >> + ASSERT(start <= end && end <= bitmapSize); > > The first ASSERT is redundant, and I would split the other ASSERT into two for better error messages. Will fix. Thanks for the review. Landed in r262167: <http://trac.webkit.org/r262167>. |