| Summary: | [css-grid] Import tests for the grid as flexbox item case | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Javier Fernandez <jfernandez> | ||||||||
| Component: | Tools / Tests | Assignee: | Javier Fernandez <jfernandez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | clopez, Lawrence.j, obrufau, rego, tsavell, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=209282 https://bugs.webkit.org/show_bug.cgi?id=212525 |
||||||||||
| Attachments: |
|
||||||||||
|
Description
Javier Fernandez
2020-05-26 06:57:37 PDT
Created attachment 400243 [details]
Patch
Created attachment 400336 [details]
Patch
These tests were already reviewed and merged upstream [1] so we can land this patch now. [1] https://github.com/web-platform-tests/wpt/pull/23769 Comment on attachment 400336 [details]
Patch
r+
Created attachment 400511 [details]
Patch
Committed r262284: <https://trac.webkit.org/changeset/262284> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400511 [details]. This import introduced 4 new test failures for Mac: imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-001.html imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-003.html imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-007.html imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-as-flex-item-should-not-shrink-to-fit-008.html History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-grid%2Flayout-algorithm%2Fgrid-as-flex-item-should-not-shrink-to-fit-001.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-grid%2Flayout-algorithm%2Fgrid-as-flex-item-should-not-shrink-to-fit-003.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-grid%2Flayout-algorithm%2Fgrid-as-flex-item-should-not-shrink-to-fit-007.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-grid%2Flayout-algorithm%2Fgrid-as-flex-item-should-not-shrink-to-fit-008.html Results: https://build.webkit.org/results/Apple-Catalina-Release-WK2-Tests/r262292%20(5933)/results.html The image diff shows a red square for each of these tests. The failures are being tracked here: https://bugs.webkit.org/show_bug.cgi?id=212525 It looks like you marked these as Failure when they should be ImageOnlyFailure Fixed the expectations here: https://trac.webkit.org/changeset/262305/webkit (In reply to Truitt Savell from comment #11) > Fixed the expectations here: https://trac.webkit.org/changeset/262305/webkit Sorry about than and thanks for the fix. |