Bug 212362

Summary: Add watchlist comment for patches touching imported WPT tests.
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, dino, ews-watchlist, glenn, jbedard, mjs, psaavedra, rniwa, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212597
Attachments:
Description Flags
Patch
none
Patch
none
Patch youennf: review+

Carlos Alberto Lopez Perez
Reported 2020-05-25 15:02:55 PDT
When a WebKit patch touches the imported WPT tests there is a currently script that runs automatically offering to export this changes to the WPT repository. However this script fails sometimes to create the corresponding WPT PR. I think it will be useful that we add a style-check trigger so it comments on bugzilla with a link to the wiki with the information about how the export process for WPT tests works. I have documented how this process works here: https://trac.webkit.org/wiki/WPTExportProcess
Attachments
Patch (3.23 KB, patch)
2020-05-25 15:09 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (3.22 KB, patch)
2020-05-25 15:14 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (3.25 KB, patch)
2020-05-26 08:17 PDT, Carlos Alberto Lopez Perez 		youennf: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2020-05-25 15:09:35 PDT
Created attachment 400222 [details] Patch
EWS Watchlist
Comment 2 2020-05-25 15:10:38 PDT
This patch modifies the imported web-platform-tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Carlos Alberto Lopez Perez
Comment 3 2020-05-25 15:14:33 PDT
Created attachment 400223 [details] Patch
youenn fablet
Comment 4 2020-05-26 06:21:42 PDT
Comment on attachment 400223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400223&action=review > Tools/Scripts/webkitpy/common/config/watchlist:481 > + "WebPlatformTests": [ "This patch modifies the imported web-platform-tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess" ], Is there a way to not have this message in case only -expected.txt files are changed? Also, it might be a bit annoying for patches that are resending from upstream. Will it happen for every patch being uploaded?
Carlos Alberto Lopez Perez
Comment 5 2020-05-26 08:14:01 PDT
(In reply to youenn fablet from comment #4) > Comment on attachment 400223 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=400223&action=review > > > Tools/Scripts/webkitpy/common/config/watchlist:481 > > + "WebPlatformTests": [ "This patch modifies the imported web-platform-tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess" ], > > Is there a way to not have this message in case only -expected.txt files are > changed? Yes, I think I can use a negative lookahead regex expression to exclude -expected.txt from the list. Good idea. > Also, it might be a bit annoying for patches that are resending from > upstream. > Will it happen for every patch being uploaded? I think it will only comment once (once per bug). It won't comment again on the same bug (even if you upload new patches to the bug).
Carlos Alberto Lopez Perez
Comment 6 2020-05-26 08:17:05 PDT
Created attachment 400248 [details] Patch
Carlos Alberto Lopez Perez
Comment 7 2020-05-29 08:03:03 PDT
Is this ok now? r?
youenn fablet
Comment 8 2020-05-29 08:06:53 PDT
Comment on attachment 400248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400248&action=review > Tools/Scripts/webkitpy/common/config/watchlist:460 > + "WebPlatformTests": [ "clopez@igalia.com" ], Can you add youennf@gmail.com as well? > Tools/Scripts/webkitpy/common/config/watchlist:481 > + "WebPlatformTests": [ "This patch modifies the imported web-platform-tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess" ], s/the imported web-platform-tests/imported WPT tests/
Carlos Alberto Lopez Perez
Comment 9 2020-05-29 08:41:12 PDT
(In reply to youenn fablet from comment #8) > Comment on attachment 400248 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=400248&action=review > > > Tools/Scripts/webkitpy/common/config/watchlist:460 > > + "WebPlatformTests": [ "clopez@igalia.com" ], > > Can you add youennf@gmail.com as well? > > > Tools/Scripts/webkitpy/common/config/watchlist:481 > > + "WebPlatformTests": [ "This patch modifies the imported web-platform-tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess" ], > > s/the imported web-platform-tests/imported WPT tests/ Ok. Thanks!
Carlos Alberto Lopez Perez
Comment 10 2020-05-29 08:47:48 PDT
Committed r262295: <https://trac.webkit.org/changeset/262295>
Radar WebKit Bug Importer
Comment 11 2020-05-29 08:48:23 PDT
<rdar://problem/63760615>
Note You need to log in before you can comment on or make changes to this bug.