| Summary: | [css-flexbox] Tables as flex items should obey the flex container sizing | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||||||||||
| Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | ap, changseok, clopez, darin, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, webkit-bug-importer, zalan | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Sergio Villar Senin
2020-05-25 09:22:46 PDT
Created attachment 400206 [details]
Patch
Created attachment 400213 [details]
Patch
Added another test that passes now
Created attachment 400217 [details]
Patch
Fixed duplicated ChangeLog
Created attachment 400237 [details]
Patch
New expectations
Created attachment 400238 [details]
Patch
Rebased. Fixed conflicts
Zalan, Darin could you take a look? Thanks! Comment on attachment 400238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400238&action=review The patch looks good to me, just a minor comment inline. > Source/WebCore/rendering/RenderTable.cpp:284 > + // is how flexible containers flex or stretch us. Nit: s/flexible containers/flex container/ (that's the term on the spec so I guess it's better to use it https://drafts.csswg.org/css-flexbox/#flex-containers). Committed r262378: <https://trac.webkit.org/changeset/262378> |