| Summary: | [css-grid] grid-template-rows can serialize to invalid syntax when set by grid-template | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oriol Brufau <obrufau> | ||||
| Component: | CSS | Assignee: | Oriol Brufau <obrufau> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jfernandez, macpherson, menard, rego, svillar, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=204611 | ||||||
| Attachments: |
|
||||||
Created attachment 400197 [details]
Patch
Comment on attachment 400197 [details]
Patch
r=me, thanks for the fix
Committed r262130: <https://trac.webkit.org/changeset/262130> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400197 [details]. |
Run this code: document.body.style.gridTemplate = "'s1' [l1] [l2] 's2'"; document.body.style.gridTemplateRows; WebKit returns "auto [l1] [l2] auto", which is invalid syntax because, unlike grid-template, grid-template-rows does not accept adjacent <line-names>. It should return "auto [l1 l2] auto", like Firefox and Chromium do.