Bug 212334

Summary: [GTK4] SDK contains too old GTK4
Product: WebKit Reporter: Alice Mikhaylenko <alicem>
Component: WebKitGTKAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, cgarcia, pnormand
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Alice Mikhaylenko 2020-05-24 07:51:08 PDT
./Tools/Scripts/build-webkit --gtk --release --cmakeargs="-DUSE_GTK4=ON"

...

-- Checking for module 'gtk4'
--   Found gtk4, version 3.98.3
-- Checking for module 'gtk4-unix-print'
--   Found gtk4-unix-print, version 3.98.3
CMake Error at /usr/share/cmake-3.15/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find GTK (missing: GTK_VERSION_OK) (Required is at least version
"3.98.4")
Comment 1 Carlos Garcia Campos 2020-05-24 07:58:47 PDT
At this moment, working on GTK4 requires to use gtk from git master and update often, so I think it's better to use jhbuild.
Comment 2 Philippe Normand 2020-05-24 08:20:50 PDT
I don't mind updating the SDK whenever you ask it, FWIW.
Comment 3 Philippe Normand 2020-05-24 08:24:29 PDT
Also, this is documented now:

http://trac.webkit.org/browser/webkit/trunk/Tools/buildstream/README.rst

In case anybody would like to try, feedback is always welcome :)
Comment 4 Philippe Normand 2020-05-24 08:34:27 PDT
Created attachment 400162 [details]
Patch
Comment 5 EWS 2020-05-25 01:17:01 PDT
Committed r262115: <https://trac.webkit.org/changeset/262115>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400162 [details].