Bug 212321

Summary:

[GTK4] Make inspector work

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, berto, bugs-noreply, ews-watchlist, gustavo

Priority:

Keywords:

Gtk

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

210100

Attachments:

Description	Flags
Patch	aperez: review+

Description Carlos Garcia Campos 2020-05-24 05:48:53 PDT

And remote inspector as well.

Comment 1 Carlos Garcia Campos 2020-05-30 05:27:28 PDT

Created attachment 400664 [details]
Patch

Comment 2 EWS Watchlist 2020-05-30 05:28:30 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Adrian Perez 2020-06-01 01:57:56 PDT

Comment on attachment 400664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400664&action=review

> Source/WebKit/ChangeLog:11
> +        (webkitWebViewBaseDispose): Use specific functions to remve the children.

Typo: remve → remove.

Comment 4 Carlos Garcia Campos 2020-06-01 02:24:12 PDT

Committed r262371: <https://trac.webkit.org/changeset/262371>