| Summary: | [GTK4] Make PointerLock work | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aperez, bugs-noreply | ||||
| Priority: | P2 | Keywords: | Gtk | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=212592 | ||||||
| Bug Depends on: | 212298 | ||||||
| Bug Blocks: | 210100 | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2020-05-24 05:40:27 PDT
Created attachment 400158 [details]
Patch
Comment on attachment 400158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400158&action=review > Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:166 > +#if USE(GTK4) You don't need this #if, we have a “gdk_event_get_root_coords()” stub in “GtkVersioning.h” which works for GTK4 :) Comment on attachment 400158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400158&action=review >> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:166 >> +#if USE(GTK4) > > You don't need this #if, we have a “gdk_event_get_root_coords()” > stub in “GtkVersioning.h” which works for GTK4 :) I left this one on purpose to avoid calling gdk_event_get_coords() again. Maybe it's not worth the super-micro-optimization, though. I'll change to improve the code readability. Committed r262187: <https://trac.webkit.org/changeset/262187> |