Bug 212278

Summary:

Make sure we clean up CFTimerRefs when destroying scrolling tree nodes

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Simon Fraser (smfr) 2020-05-22 13:55:24 PDT

Make sure we clean up CFTimerRefs when destroying scrolling tree nodes

Comment 1 Simon Fraser (smfr) 2020-05-22 13:58:12 PDT

Created attachment 400073 [details]
Patch

Comment 2 Simon Fraser (smfr) 2020-05-22 13:58:15 PDT

<rdar://problem/63548212>

Comment 3 Tim Horton 2020-05-22 13:59:38 PDT

Comment on attachment 400073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400073&action=review

> Source/WebCore/page/scrolling/ScrollingTree.cpp:344
> +        iter.value->willBeDestroyed();

This isn't going to mutate the map?

Comment 4 EWS 2020-05-22 14:52:41 PDT

Committed r262076: <https://trac.webkit.org/changeset/262076>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400073 [details].