Bug 212256

Summary:

[GTK] jhbuild is broken with GCC 10.0

Product:

WebKit

Reporter:

ChangSeok Oh <changseok>

Component:

WebKitGTK

Assignee:

ChangSeok Oh <changseok>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, bugs-noreply, calvaris, clopez, ews-watchlist, ltilve

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description ChangSeok Oh 2020-05-22 02:07:54 PDT

GCC 10 has -fno-common as default. It causes many multiple definition issues to build dependencies in jhbuild. I know we have moved to flatpak sdk but there may be someone who needs a fix for the issue like me.

Comment 1 ChangSeok Oh 2020-05-22 07:39:40 PDT

Created attachment 400045 [details]
Patch

Comment 2 ChangSeok Oh 2020-05-22 10:33:24 PDT

Comment on attachment 400045 [details]
Patch

Thanks for your review!

Comment 3 EWS 2020-05-22 10:35:47 PDT

Committed r262063: <https://trac.webkit.org/changeset/262063>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400045 [details].