| Summary: | iOS: Pressing tab in the Mail subject field moves focus to the body, but pressing shift tab doesn't move it back | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | megan_gardner, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2020-05-21 17:28:33 PDT
Created attachment 400004 [details]
Patch
*** Bug 212242 has been marked as a duplicate of this bug. *** Comment on attachment 400004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400004&action=review > Source/WebCore/page/FocusController.cpp:453 > + Document* document = focusedOrMainFrame().document(); I think we generally prefer the strong ref here, as it’s not clear that the code below won’t nuke document. > Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:847 > + TestWebKitAPI::Util::run(&delegate.get()->_done); Nit - I don’t think you need the .get() here. > Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:862 > + TestWebKitAPI::Util::run(&delegate.get()->_done); Ditto. > Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:876 > + TestWebKitAPI::Util::run(&delegate.get()->_didSendKeyEvent); Ditto. > Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:878 > + ASSERT_FALSE(delegate.get()->_done); Ditto. Created attachment 400035 [details]
Patch
Committed r262051: <https://trac.webkit.org/changeset/262051> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400035 [details]. |