Bug 212170

Summary: OES_texture_half_float_linear unavailable on WebGL 1.0 on iOS with ANGLE
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, jdarpinian, justin_fan, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 210524, 212005    
Bug Blocks: 126404, 212228    
Attachments:
Description Flags
Patch
none
Patch dino: review+, kbr: commit-queue+

Kenneth Russell
Reported 2020-05-20 15:08:58 PDT
The WebGL extension OES_texture_half_float_linear is unavailable on iOS (tested locally on the simulator) with WebKit's ANGLE backend for WebGL. ANGLE isn't advertising this extension to OpenGL ES 2.0 contexts when it's using an OpenGL ES 3.0 context under the hood. Once Bug 210524 is addressed and OES_texture_half_float is properly exposed, this must be fixed as well to avoid regressions.
Attachments
Patch (7.46 KB, patch)
2020-05-20 17:09 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (24.43 KB, patch)
2020-05-20 17:28 PDT, Kenneth Russell 		dino: review+
kbr: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-05-20 17:09:31 PDT
Created attachment 399915 [details] Patch
Kenneth Russell
Comment 2 2020-05-20 17:11:29 PDT
Attached is the needed patch to ANGLE. Not ready for review or EWS testing yet; it depends on the patch for Bug 210524 landing. Have tested this minimally on the iOS Simulator; it makes the oes-texture-half-float-linear.html test pass, and the extension is actually enabled.
Kenneth Russell
Comment 3 2020-05-20 17:28:44 PDT
Created attachment 399918 [details] Patch
EWS Watchlist
Comment 4 2020-05-20 17:29:32 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Dean Jackson
Comment 5 2020-05-20 17:35:29 PDT
Committed r261976: <https://trac.webkit.org/changeset/261976>
Radar WebKit Bug Importer
Comment 6 2020-05-20 17:36:15 PDT
<rdar://problem/63471341>
Note You need to log in before you can comment on or make changes to this bug.