| Summary: | [Mac,WK2] Fullscreen animation missing a few frames at beginning | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric.carlson, peng.liu6, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jer Noble
2020-05-20 11:28:24 PDT
Created attachment 399863 [details]
Patch
Comment on attachment 399863 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399863&action=review > Source/WebKit/ChangeLog:9 > + When starting the animation, ensure that the fullscreen window is ordered front, and on top s/the animation/the enter fullscreen animation/ > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:325 > + [clipLayer addAnimation:zoomAnimation(_initialFrame, _finalFrame, self.window.screen.frame, 1e10, AnimateIn) forKey:@"fullscreen"]; > + clipLayer.mask = createMask(contentView.bounds); > + [clipLayer.mask addAnimation:maskAnimation(_initialFrame, _finalFrame, self.window.screen.frame, 1e10, AnimateIn) forKey:@"fullscreen"]; `1e10` probably deserves a named constant to make it clear why we use it. Created attachment 400360 [details]
Patch for landing
Addressed Eric's comments. Rather than giving the duration an arbitrarily long duration, we just give the animations a duration value of 1 and a speed of 0.
Committed r262322: <https://trac.webkit.org/changeset/262322> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400360 [details]. |