Bug 212113

Summary: [css-grid] computeMarginLogicalSizeForChild checks auto margins in the opposite axis for orthogonal items
Product: WebKit Reporter: Oriol Brufau <obrufau>
Component: CSSAssignee: Oriol Brufau <obrufau>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212055
Attachments:
Description Flags
Patch none

Description Oriol Brufau 2020-05-19 17:03:31 PDT 
Like bug 212055, but for computeMarginLogicalSizeForChild.
This makes grid-items-minimum-width-orthogonal-001.html fail some cases.
Comment 1 Oriol Brufau 2020-05-19 17:16:38 PDT 
Created attachment 399786 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2020-05-19 23:57:55 PDT 
Comment on attachment 399786 [details]
Patch

Thanks for the fix, LGTM.
Comment 3 EWS 2020-05-20 00:11:30 PDT 
Committed r261907: <https://trac.webkit.org/changeset/261907>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399786 [details].
Comment 4 Radar WebKit Bug Importer 2020-05-20 00:12:15 PDT 
<rdar://problem/63434636>