| Summary: | WTF::LockedPrintStream should be final | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||
| Component: | Web Template Framework | Assignee: | Adrian Perez <aperez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 399767 [details]
Patch
Comment on attachment 399767 [details]
Patch
OK, why not.
Committed r261886: <https://trac.webkit.org/changeset/261886> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399767 [details]. |
As Clang wisely advises: ../Source/WTF/wtf/LockedPrintStream.h:38:26: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class] ~LockedPrintStream() final; ^ ../Source/WTF/wtf/LockedPrintStream.h:35:7: note: mark 'WTF::LockedPrintStream' as 'final' to silence this warning class LockedPrintStream : public PrintStream { ^ 1 warning generated.