Bug 212097

Summary: Blue dotted underline with alternatives only shown for last word, gets lost for previous insertions
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, mifenton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212093
https://bugs.webkit.org/show_bug.cgi?id=212098
Attachments:
Description Flags
Patch
none
Patch
none
To Land none

Description Daniel Bates 2020-05-19 11:41:10 PDT 
When space separated dictation alternatives are inserted only the last inserted one has blue dots.
Comment 1 Daniel Bates 2020-05-19 11:41:40 PDT 
<rdar://problem/61913405>
Comment 2 Daniel Bates 2020-05-19 13:11:06 PDT 
Created attachment 399763 [details]
Patch
Comment 3 Daniel Bates 2020-05-19 14:16:02 PDT 
Comment on attachment 399763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399763&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InsertTextAlternatives.mm:365
> +    // FIXME: Set CSS white-space to workaround <https://webkit.org/b/212093>.

Actually, works around <https://webkit.org/b/212098> because space converted to no-break space.
Comment 4 Daniel Bates 2020-05-19 14:20:36 PDT 
Created attachment 399770 [details]
Patch

Just cosmetic fixing of comments
Comment 5 Daniel Bates 2020-05-19 14:38:22 PDT 
Comment on attachment 399770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399770&action=review

> Source/WebCore/ChangeLog:28
> +        if it is a space or newline. This will be false when there is no preceeding character (e.g. start of document),

preceeding => preceding

> Source/WebCore/ChangeLog:31
> +        because that would incorrectly return false if the current selection is at the of a paragraph. I could have

the of => the end of

> Source/WebCore/ChangeLog:35
> +        start of the last word positions before mutating them. Update early returns checks to use these saved values

returns => return

> Source/WebCore/ChangeLog:40
> +        * editing/Editor.h: While I am here, fix up a param name to match the what it is called in the impl.

the what => what
impl => .cpp
Comment 6 Daniel Bates 2020-05-19 16:59:27 PDT 
Thanks Darin.
Comment 7 Daniel Bates 2020-05-19 17:04:39 PDT 
Created attachment 399785 [details]
To Land
Comment 8 Daniel Bates 2020-05-19 17:05:52 PDT 
Committed r261897: <https://trac.webkit.org/changeset/261897>