Bug 212054

Summary:

[css-flexbox] WPT Test css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html fails

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

CSS

Assignee:

Carlos Alberto Lopez Perez <clopez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, clopez, jfernandez, rego, svillar, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=211891
https://github.com/web-platform-tests/wpt/pull/23761

Attachments:

Description	Flags
Patch	none
Patch	rego: review+

Description Carlos Alberto Lopez Perez 2020-05-18 17:28:09 PDT

The WPT test css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html fails on Mac and iOS

The failure its just some small pixel differences in the text rendering, likely related to font kerning differences.

See: https://wpt.fyi/analyzer?screenshot=sha1%3Acd49a443027a6deb9e65fdec779db7fd2a3ed532&screenshot=sha1%3A28b192ce9f5c2d626bf5243b8b3e3fa79652cfb0

This test passes on GTK/WPE.


Likely this test can be fixed by using Ahem font.


For a very similar issue on other of this tests see bug 211891

Comment 1 Carlos Alberto Lopez Perez 2020-05-25 13:58:18 PDT

Created attachment 400219 [details]
Patch

Comment 2 Carlos Alberto Lopez Perez 2020-05-25 14:08:51 PDT

Created attachment 400220 [details]
Patch

Comment 3 Manuel Rego Casasnovas 2020-05-25 22:12:41 PDT

Comment on attachment 400220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400220&action=review

r=me, the change looks good just a minor comment about using red color.
Apart from that I'm not sure if I need to review the PR in WPT or it's enough with the review here, please let me know. Thanks for the fix.

> LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html:25
> +        color: red;

Please avoid using "red" for things that are on the expected output (as red usually means wrong behavior). Just change it for another color.

Comment 4 Carlos Alberto Lopez Perez 2020-05-26 01:45:21 PDT

(In reply to Manuel Rego Casasnovas from comment #3)
> Comment on attachment 400220 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=400220&action=review
> 
> r=me, the change looks good just a minor comment about using red color.
> Apart from that I'm not sure if I need to review the PR in WPT or it's
> enough with the review here, please let me know. Thanks for the fix.
> 

That is not necessary. There is a bot that will approve the WPT PR after getting review here. Check: https://trac.webkit.org/wiki/WPTExportProcess

> > LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html:25
> > +        color: red;
> 
> Please avoid using "red" for things that are on the expected output (as red
> usually means wrong behavior). Just change it for another color.

Sure, I will use orange instead.

Thanks!

Comment 5 Carlos Alberto Lopez Perez 2020-05-26 01:46:53 PDT

Committed r262139: <https://trac.webkit.org/changeset/262139>

Comment 6 Radar WebKit Bug Importer 2020-05-26 01:47:15 PDT

<rdar://problem/63615863>