| Summary: | WebPageProxy::DidCommitLoadForFrame should use FrameLoadType instead of casting to/from uint32_t for IPC | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ddkilzer, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2020-05-18 09:19:08 PDT
Created attachment 399650 [details]
Patch
Created attachment 399653 [details]
Patch
Comment on attachment 399653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399653&action=review r=me > Source/WebKit/UIProcess/WebPageProxy.messages.in:128 > + DidCommitLoadForFrame(WebCore::FrameIdentifier frameID, struct WebKit::FrameInfoData frameInfo, WebCore::ResourceRequest request, uint64_t navigationID, String mimeType, bool hasCustomContentProvider, enum:uint8_t WebCore::FrameLoadType loadType, WebCore::CertificateInfo certificateInfo, bool usedLegacyTLS, bool containsPluginDocument, Optional<WebCore::HasInsecureContent> forcedHasInsecureContent, enum:uint8_t WebCore::MouseEventPolicy mouseEventPolicy, WebKit::UserData userData) I haven't seen `enum:uint8_t` used before. Is this change so you don't have to tell messages.py about the header include for the type? What happens if the size changes in the header where it's defined? Comment on attachment 399653 [details]
Patch
it's to tell messages.py to generate the declaration namespace WebCore { enum class FrameLoadType : uint8_t; }
If the size changes, this will cause build failures until you update all these. That doesn't happen often, though.
Committed r261829: <https://trac.webkit.org/changeset/261829> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399653 [details]. |