Bug 211930

Summary:

Web Inspector: Fails to pretty-print a particular CSS file

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

URL:

https://account.ikonpass.com/en/login

Attachments:

Description	Flags
Screenshot	none
Screenshot 2	none
Resource	none
Patch	none
Patch	none

Myles C. Maxfield

Reported 2020-05-14 16:01:18 PDT

Created attachment 399421 [details] Screenshot Load https://account.ikonpass.com/packs/css/application-1cd9da5f.chunk.css in the pretty-printer in the inspector. It seems to get confused about a data url. Screenshots attached.

Attachments
Screenshot (412.42 KB, image/png) 2020-05-14 16:01 PDT, Myles C. Maxfield	no flags	Details
Screenshot 2 (368.15 KB, image/png) 2020-05-14 16:01 PDT, Myles C. Maxfield	no flags	Details
Resource (171.90 KB, text/css) 2020-05-14 16:02 PDT, Myles C. Maxfield	no flags	Details
Patch (24.41 KB, patch) 2020-05-14 18:41 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (24.57 KB, patch) 2020-05-15 17:23 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2020-05-14 16:01:31 PDT

Created attachment 399422 [details] Screenshot 2

Myles C. Maxfield

Comment 2 2020-05-14 16:02:04 PDT

Created attachment 399423 [details] Resource

Devin Rousso

Comment 3 2020-05-14 18:41:27 PDT

Created attachment 399438 [details] Patch

Devin Rousso

Comment 4 2020-05-14 18:42:39 PDT

Comment on attachment 399438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399438&action=review > Source/WebInspectorUI/UserInterface/Workers/Formatter/CSSFormatter.js:-232 > - let specialSequenceEnd = null; All the removed lines above this line have just been move outside of the `for` and haven't been changed in any way.

Joseph Pecoraro

Comment 5 2020-05-15 11:14:29 PDT

Comment on attachment 399438 [details] Patch rs=me

Devin Rousso

Comment 6 2020-05-15 17:23:54 PDT

Created attachment 399532 [details] Patch add logic to cover the edge case where we're processing a special sequence and exhaust the `_sourceText`

EWS

Comment 7 2020-05-15 18:17:25 PDT

Committed r261772: <https://trac.webkit.org/changeset/261772> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399532 [details].

Radar WebKit Bug Importer

Comment 8 2020-05-15 18:18:16 PDT

<rdar://problem/63297001>

Note You need to log in before you can comment on or make changes to this bug.