| Summary: | Do more speculation that a GetByVal/PutByVal will have an int32 index based on data from ArrayProfile | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | benjamin, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ross.kirsling, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 211935 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Saam Barati
2020-05-13 20:02:20 PDT
Created attachment 399327 [details]
WIP
Created attachment 399671 [details]
WIP
~2.5x faster on microbenchmarks/get-and-put-by-val-double-index-dont-fall-off-a-cliff.js
Might hold off a bit until final tuning and landing of this.
Even simpler, and a 3.75x speedup Created attachment 399678 [details]
patch
Created attachment 399679 [details]
patch
rebased
Created attachment 399680 [details]
patch
Comment on attachment 399680 [details]
patch
r=me
Committed r261842: <https://trac.webkit.org/changeset/261842> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399680 [details]. |