| Summary: | Making 32-bits JIT build without Unified Build system | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Caio Lima <ticaiolima> | ||||
| Component: | JavaScriptCore | Assignee: | Caio Lima <ticaiolima> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aperez, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Caio Lima
2020-05-13 11:20:08 PDT
Created attachment 399282 [details]
Patch
Comment on attachment 399282 [details]
Patch
LGTM; please make sure the EWS builders stay green before landing 🙂️
Comment on attachment 399282 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399282&action=review > Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:1230 > +template void JIT::emit_op_put_by_val<OpPutByVal>(const Instruction*); > + Why is this needed? (In reply to Mark Lam from comment #3) > Comment on attachment 399282 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=399282&action=review > > > Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:1230 > > +template void JIT::emit_op_put_by_val<OpPutByVal>(const Instruction*); > > + > > Why is this needed? It is necessary to generate `JIT::emit_op_put_by_val<OpPutByVal>` and allow it be called by `JIT.cpp`. IIUC, without it, `JIT::emit_op_put_by_val<OpPutByVal>` will never be generated and we will have an issue during linking phase. Comment on attachment 399282 [details]
Patch
Thank you very much for the review!
Committed r261642: <https://trac.webkit.org/changeset/261642> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399282 [details]. |