| Summary: | [buildbot] Increase blocksize of file transfer in UploadTestResults step | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||
| Component: | New Bugs | Assignee: | Diego Pino <dpino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ews-watchlist, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Diego Pino
2020-05-13 09:40:17 PDT
Created attachment 399274 [details]
Patch
All other steps involving file transfers set their blocksize as 256Kb (build.webkit.org-config/steps.py:UploadBuiltProduct, ews-build/steps.py:UploadBuiltProduct and ews-build/steps.py:UploadTestResults). In the case of the GTK and WPE test bots, the UploadTestResults is particularly slow. Digging into this issue I found out a small blocksize might be a reason for slow file transfers in Buildbot, specially in the case of big files (https://github.com/buildbot/buildbot/pull/4354). In particular, Buildbot v1.6.0 fixed this issue by making the default file transfer blocksize 256Kb, and I think this might be the reason why all the other file transfer steps have set their blocksize to this value. (In reply to Diego Pino from comment #2) > specially in the case of big files (https://github.com/buildbot/buildbot/pull/4354). In particular, Buildbot v1.6.0 fixed this issue by making the default file transfer blocksize 256Kb Yup! I remember making that PR in buildbot. Committed r261739: <https://trac.webkit.org/changeset/261739> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399274 [details]. |