| Summary: | [IWYU] Try removing redundant includes in WTF implementation files | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||||||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, darin, don.olmstead, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, simon.fraser, webkit-bug-importer, ysuzuki | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Ross Kirsling
2020-05-12 17:47:22 PDT
Created attachment 399210 [details]
Patch
An initial experiment to see whether/how include-what-you-use could be of benefit to us. Procedure: - build non-unified JSCOnly on Mac - run `iwyu_tool.py ../../Source/WTF/wtf/ -p .` from build dir - manually examine recommended removals There are a slew of unfortunate things here... - for additions, they don't seem to like indirect dependencies, which seems to be in opposition to WK style - for removals, they want "config.h" removed from every file - I'm not sure if there's a way to prune includes from *headers*, which would be way more useful ...but there are still a lot of removals here so it's pretty neat if you have the patience? Created attachment 399213 [details]
Patch
Created attachment 399214 [details]
Patch
Created attachment 399216 [details]
Patch
Created attachment 399219 [details]
Patch
Created attachment 399224 [details]
Patch
Committed r261661: <https://trac.webkit.org/changeset/261661> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399224 [details]. |