| Summary: | Fix MobileMiniBrowser build without internal SDK | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||
| Component: | New Bugs | Assignee: | James Darpinian <jdarpinian> | ||||
| Status: | ASSIGNED --- | ||||||
| Severity: | Normal | CC: | ap, dino, jer.noble, justin_fan, kbr | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
James Darpinian
2020-05-12 17:23:41 PDT
Created attachment 399207 [details]
Patch
Comment on attachment 399207 [details]
Patch
Please don’t modify the project, such settings should be in xcconfigs.
I’m not sure if this is the right fix even in xcconfigs, what do other projects do?
+jer.noble Could we please ask for some help understanding how to make this patch correct? Thanks. It would be a great help for the open-source contributors working on the simulator. Can you try adding this to DebugRelease.xcconfig? I don't understand how this works, but there is something that makes "macosx" actually appropriate for iOS, and we have this in other projects. SDKROOT = $(SDKROOT_$(USE_INTERNAL_SDK)); SDKROOT_ = macosx; SDKROOT_YES = macosx.internal; |