Bug 211819

Summary: Fix MobileMiniBrowser build without internal SDK
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: New BugsAssignee: James Darpinian <jdarpinian>
Status: ASSIGNED    
Severity: Normal CC: ap, dino, jer.noble, justin_fan, kbr
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review-

James Darpinian
Reported 2020-05-12 17:23:41 PDT
Fix MobileMiniBrowser build without internal SDK
Attachments
Patch (1.53 KB, patch)
2020-05-12 17:25 PDT, James Darpinian 		ap: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2020-05-12 17:25:03 PDT
Created attachment 399207 [details] Patch
Alexey Proskuryakov
Comment 2 2020-05-12 18:32:18 PDT
Comment on attachment 399207 [details] Patch Please don’t modify the project, such settings should be in xcconfigs. I’m not sure if this is the right fix even in xcconfigs, what do other projects do?
Kenneth Russell
Comment 3 2020-07-10 17:10:27 PDT
+jer.noble Could we please ask for some help understanding how to make this patch correct? Thanks. It would be a great help for the open-source contributors working on the simulator.
Alexey Proskuryakov
Comment 4 2020-07-10 17:55:54 PDT
Can you try adding this to DebugRelease.xcconfig? I don't understand how this works, but there is something that makes "macosx" actually appropriate for iOS, and we have this in other projects. SDKROOT = $(SDKROOT_$(USE_INTERNAL_SDK)); SDKROOT_ = macosx; SDKROOT_YES = macosx.internal;
Note You need to log in before you can comment on or make changes to this bug.