Bug 211810

Summary:

handling of Check in VarargsForwardingPhase is too pessimistic

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ross.kirsling, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	keith_miller: review+
patch for landing	none

Description Saam Barati 2020-05-12 15:30:05 PDT

...

Comment 1 Saam Barati 2020-05-12 16:03:47 PDT

Created attachment 399194 [details]
patch

Comment 2 Keith Miller 2020-05-12 16:05:39 PDT

Comment on attachment 399194 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399194&action=review

r=me.

> JSTests/microbenchmarks/forward-varargs-check-shouldnt-escape.js:14
> +// print(Date.now() - start);

Plox delete.

Comment 3 Saam Barati 2020-05-12 17:09:03 PDT

Created attachment 399205 [details]
patch for landing

Comment 4 EWS 2020-05-12 20:05:01 PDT

Committed r261595: <https://trac.webkit.org/changeset/261595>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399205 [details].

Comment 5 Radar WebKit Bug Importer 2020-05-12 20:06:13 PDT

<rdar://problem/63166410>