Bug 211795

Summary: [iOS] Port Foreground process assertion to RunningBoard
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ggaren, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2020-05-12 12:51:37 PDT 
Port Foreground process assertion to RunningBoard.
Comment 1 Chris Dumez 2020-05-12 12:51:56 PDT 
<rdar://problem/61831863>
Comment 2 Chris Dumez 2020-05-12 12:55:44 PDT 
Created attachment 399157 [details]
Patch
Comment 3 Geoffrey Garen 2020-05-12 13:10:36 PDT 
Comment on attachment 399157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399157&action=review

r=me

> Source/WebKit/Configurations/WebKit.xcconfig:60
> +// FIXME: It is unnecessary to link against AssertionServices with the latest SDK for the following platforms too.
> +WK_ASSERTION_SERVICES_LDFLAGS_watchos = -framework AssertionServices;
> +WK_ASSERTION_SERVICES_LDFLAGS_watchsimulator = -framework AssertionServices;
> +WK_ASSERTION_SERVICES_LDFLAGS_appletvos = -framework AssertionServices;
> +WK_ASSERTION_SERVICES_LDFLAGS_appletvsimulator = -framework AssertionServices;
> +WK_ASSERTION_SERVICES_LDFLAGS_maccatalyst = -framework AssertionServices;

Is this about building using the old SDK? (Do we do that?)
Comment 4 Chris Dumez 2020-05-12 13:11:45 PDT 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 399157 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399157&action=review
> 
> r=me
> 
> > Source/WebKit/Configurations/WebKit.xcconfig:60
> > +// FIXME: It is unnecessary to link against AssertionServices with the latest SDK for the following platforms too.
> > +WK_ASSERTION_SERVICES_LDFLAGS_watchos = -framework AssertionServices;
> > +WK_ASSERTION_SERVICES_LDFLAGS_watchsimulator = -framework AssertionServices;
> > +WK_ASSERTION_SERVICES_LDFLAGS_appletvos = -framework AssertionServices;
> > +WK_ASSERTION_SERVICES_LDFLAGS_appletvsimulator = -framework AssertionServices;
> > +WK_ASSERTION_SERVICES_LDFLAGS_maccatalyst = -framework AssertionServices;
> 
> Is this about building using the old SDK? (Do we do that?)

Yes, we need to keep building on shipping.
Comment 5 EWS 2020-05-19 08:31:43 PDT 
Committed r261860: <https://trac.webkit.org/changeset/261860>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399157 [details].