| Summary: | Fix existing usage of final/override/virtual in JSC and WTF | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bburg, benjamin, cdumez, cmarcelo, darin, don.olmstead, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=211743 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ross Kirsling
2020-05-11 23:23:04 PDT
Created attachment 399103 [details]
Patch
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) This extends the unautomable part of bug 211743 to the areas of JSC and WTF that clang-tidy didn't have a qualm with. Created attachment 399104 [details]
Patch
(In reply to Ross Kirsling from comment #3) > This extends the unautomable part of bug 211743 to the areas of JSC and WTF > that clang-tidy didn't have a qualm with. (Er rather, this patch does include modernize-use-override autofixes for WTF too, because the previous patch just touched JSC.) Created attachment 399105 [details]
Patch
Created attachment 399106 [details]
Patch
Comment on attachment 399106 [details]
Patch
Looks fine, rs=me
Comment on attachment 399106 [details]
Patch
Dammit, the previous patch got rolled out; guess I'll cq- for a moment to keep things in order.
Committed r261569: <https://trac.webkit.org/changeset/261569> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399106 [details]. |