| Summary: | WebGLLayer clobbers TEXTURE_2D binding on iOS | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||||||
| Component: | ANGLE | Assignee: | James Darpinian <jdarpinian> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, justin_fan, kbr, kkinnunen, kondapallykalyan, noam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 207858, 183151 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
James Darpinian
2020-05-11 17:34:26 PDT
Created attachment 399075 [details]
Patch
Fixes tests: fast/canvas/webgl/webgl-texture-binding-preserved.html webgl/1.0.3/conformance/canvas/texture-bindings-unaffected-on-resize.html webgl/1.0.3/conformance/extensions/oes-element-index-uint.html webgl/1.0.3/conformance/misc/delayed-drawing.html webgl/1.0.3/conformance/misc/uninitialized-test.html webgl/1.0.3/conformance/state/state-uneffected-after-compositing.html webgl/1.0.3/conformance/textures/default-texture.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgb565.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba4444.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba5551.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas.html Created attachment 399085 [details]
EWS test
Committed r261541: <https://trac.webkit.org/changeset/261541> Great work James finding and fixing this! Reopening to attach new patch. Created attachment 406924 [details]
Patch
Comment on attachment 406924 [details]
Patch
Hi Kimmo!
This patch looks fine since it's small and didn't mark the old one as obsolete. In the future though please file new bugs and block them on the old ones. WebKit's bug process is best set up for one patch per bug.
Setting r+.
Committed r266009: <https://trac.webkit.org/changeset/266009> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406924 [details]. |