Bug 211758

Summary: WebGLLayer clobbers TEXTURE_2D binding on iOS
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: ANGLEAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, justin_fan, kbr, kkinnunen, kondapallykalyan, noam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 207858, 183151    
Attachments:
Description Flags
Patch
none
EWS test
none
Patch none

James Darpinian
Reported 2020-05-11 17:34:26 PDT
WebGLLayer clobbers TEXTURE_2D binding on iOS
Attachments
Patch (4.66 KB, patch)
2020-05-11 17:37 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
EWS test (5.05 KB, patch)
2020-05-11 18:56 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (3.15 KB, patch)
2020-08-20 04:50 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2020-05-11 17:37:53 PDT
Created attachment 399075 [details] Patch
James Darpinian
Comment 2 2020-05-11 17:53:13 PDT
Fixes tests: fast/canvas/webgl/webgl-texture-binding-preserved.html webgl/1.0.3/conformance/canvas/texture-bindings-unaffected-on-resize.html webgl/1.0.3/conformance/extensions/oes-element-index-uint.html webgl/1.0.3/conformance/misc/delayed-drawing.html webgl/1.0.3/conformance/misc/uninitialized-test.html webgl/1.0.3/conformance/state/state-uneffected-after-compositing.html webgl/1.0.3/conformance/textures/default-texture.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgb565.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba4444.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba5551.html webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas.html
Dean Jackson
Comment 3 2020-05-11 18:56:42 PDT
Created attachment 399085 [details] EWS test
Dean Jackson
Comment 4 2020-05-11 19:52:21 PDT
Committed r261541: <https://trac.webkit.org/changeset/261541>
Radar WebKit Bug Importer
Comment 5 2020-05-11 19:53:16 PDT
<rdar://problem/63117651>
Kenneth Russell
Comment 6 2020-05-12 08:48:19 PDT
Great work James finding and fixing this!
Kimmo Kinnunen
Comment 7 2020-08-20 04:50:25 PDT
Reopening to attach new patch.
Kimmo Kinnunen
Comment 8 2020-08-20 04:50:28 PDT
Created attachment 406924 [details] Patch
Kenneth Russell
Comment 9 2020-08-20 09:52:04 PDT
Comment on attachment 406924 [details] Patch Hi Kimmo! This patch looks fine since it's small and didn't mark the old one as obsolete. In the future though please file new bugs and block them on the old ones. WebKit's bug process is best set up for one patch per bug. Setting r+.
EWS
Comment 10 2020-08-21 10:43:59 PDT
Committed r266009: <https://trac.webkit.org/changeset/266009> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406924 [details].
Note You need to log in before you can comment on or make changes to this bug.