Bug 211727

Summary: [Flatpak] pass help argument to flatpak command not to gst-env.py
Product: WebKit Reporter: Víctor M. Jáquez L. <vjaquez>
Component: Tools / TestsAssignee: Víctor M. Jáquez L. <vjaquez>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, clopez, pnormand
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch none

Description Víctor M. Jáquez L. 2020-05-11 08:04:07 PDT
When running run-minibrowser --help, for example, with the envvar GST_BUILD_PATH, we get the gst-env.py help, not minibrowser's.
Comment 1 Víctor M. Jáquez L. 2020-05-11 08:08:53 PDT
Created attachment 399021 [details]
Patch
Comment 2 Philippe Normand 2020-05-11 10:01:18 PDT
Comment on attachment 399021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399021&action=review

> Tools/flatpak/flatpakutils.py:791
> +        request_help = '-h' in args or '--help' in args

Is there no better way to handle this?
Comment 3 Víctor M. Jáquez L. 2020-05-13 08:55:49 PDT
(In reply to Philippe Normand from comment #2)
> Comment on attachment 399021 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399021&action=review
> 
> > Tools/flatpak/flatpakutils.py:791
> > +        request_help = '-h' in args or '--help' in args
> 
> Is there no better way to handle this?

I'm sure there should be one, but I can't see it :S
Comment 4 Víctor M. Jáquez L. 2020-05-27 07:04:51 PDT
reopen. I thought it was other bug.
Comment 5 Víctor M. Jáquez L. 2020-05-29 10:02:09 PDT
fixed by commit r262297