| Summary: | [macOS] Search field on mayoclinic.org/forms/us-resident-appointment clips the submit button | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Component: | Forms | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bdakin, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, thorton, webkit-bug-importer, wenson_hsieh, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Wenson Hsieh
2020-05-09 16:10:37 PDT
Created attachment 398949 [details]
Patch
Comment on attachment 398949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398949&action=review > Source/WebCore/rendering/RenderThemeMac.mm:869 > - if (style.appearance() == TextFieldPart || style.appearance() == TextAreaPart || style.appearance() == ListboxPart) > + if (style.appearance() == TextFieldPart || style.appearance() == TextAreaPart || style.appearance() == SearchFieldPart || style.appearance() == ListboxPart) At what point do we store appearance in a local to neaten this up? Comment on attachment 398949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398949&action=review Thanks for the review! >> Source/WebCore/rendering/RenderThemeMac.mm:869 >> + if (style.appearance() == TextFieldPart || style.appearance() == TextAreaPart || style.appearance() == SearchFieldPart || style.appearance() == ListboxPart) > > At what point do we store appearance in a local to neaten this up? Fair point — I’ll go ahead and pull style.appearance() into a local variable while I’m here Created attachment 398953 [details]
Patch for landing
Created attachment 398954 [details]
Patch for landing
Committed r261450: <https://trac.webkit.org/changeset/261450> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398954 [details]. |