Bug 211657

Summary: Re-enable 'VisuallyIdle' RenderingUpdate throttling
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: NEW ---    
Severity: Normal CC: bfulgham, cdumez, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204713
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Said Abou-Hallawa 2020-05-08 20:06:11 PDT 
The VisuallyIdle throttling was not implemented in r261113. The goal of the VisuallyIdle throttling is to save power by throttling the RenderingUpdate when the Page is VisuallyIdle. The page is in 'VisuallyIdle' state when it is invisible or when the Window server stopped modifying the host application.
Comment 1 Said Abou-Hallawa 2020-05-09 00:59:47 PDT 
Created attachment 398921 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-05-11 10:33:21 PDT 
Comment on attachment 398921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398921&action=review

> Source/WebCore/platform/graphics/AnimationFrameRate.h:77
>  inline TextStream& operator<<(TextStream& ts, const OptionSet<ThrottlingReason>& reasons)

TextStream already knows how to dump OptionSet<>, so you just need dumping for ThrottlingReason.
Comment 3 Said Abou-Hallawa 2020-05-15 14:22:35 PDT 
Created attachment 399511 [details]
Patch
Comment 4 Said Abou-Hallawa 2020-05-15 17:04:16 PDT 
Created attachment 399528 [details]
Patch
Comment 5 Said Abou-Hallawa 2020-05-15 19:02:57 PDT 
Created attachment 399538 [details]
Patch