Bug 211643

Summary: Array.prototype.concat fast path checks should not be observable
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Trivial CC: ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=184267
Attachments:
Description Flags
Patch
none
Patch none

Description Alexey Shvayka 2020-05-08 14:32:06 PDT 
Array.prototype.concat fast path checks should not be observable
Comment 1 Alexey Shvayka 2020-05-08 14:35:32 PDT 
Created attachment 398889 [details]
Patch
Comment 2 Alexey Shvayka 2020-05-08 14:40:56 PDT 
Created attachment 398890 [details]
Patch

Tweak ChangeLog.
Comment 3 Ross Kirsling 2020-05-08 14:43:16 PDT 
Comment on attachment 398890 [details]
Patch

Nice, glad to see that intrinsic is coming in handy. :)
Comment 4 Alexey Shvayka 2020-05-08 17:02:51 PDT 
(In reply to Ross Kirsling from comment #3)
> Comment on attachment 398890 [details]
> Patch
> 
> Nice, glad to see that intrinsic is coming in handy. :)

Good job on implementing it and thanks for review!
ARMv7 failure is unrelated: https://webkit.org/b/211313.
Comment 5 EWS 2020-05-08 18:43:47 PDT 
Committed r261430: <https://trac.webkit.org/changeset/261430>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398890 [details].
Comment 6 Radar WebKit Bug Importer 2020-05-08 18:44:16 PDT 
<rdar://problem/63044859>