| Summary: | webkitpy: 'iPhone SE' should match 'iPhone SE 1st generation' | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, ap, ews-watchlist, giffypap79, glenn, ryanhaddad, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jonathan Bedard
2020-05-08 13:58:15 PDT
Created attachment 398886 [details]
Patch
Comment on attachment 398886 [details]
Patch
rs=me
Comment on attachment 398886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398886&action=review > Tools/Scripts/webkitpy/xcode/device_type_unittest.py:164 > + self.assertTrue(DeviceType.from_string('iPhone SE') == DeviceType.from_string('iPhone SE 1st generation')) Is this the actual string? I thought that there were parentheses there. Created attachment 398893 [details]
Patch
(In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 398886 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398886&action=review > > > Tools/Scripts/webkitpy/xcode/device_type_unittest.py:164 > > + self.assertTrue(DeviceType.from_string('iPhone SE') == DeviceType.from_string('iPhone SE 1st generation')) > > Is this the actual string? I thought that there were parentheses there. There are, and I missed a check we need in the case that we don't have an existing simulator with the type. Uploaded a new patch. Created attachment 398896 [details]
Patch for landing
Committed r261421: <https://trac.webkit.org/changeset/261421> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398896 [details]. |